search

deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
625 stars 85 forks source link

Build xpi at time of release #39

Closed reesericci closed 3 years ago

reesericci commented 3 years ago

that way the end user can skip the building step and only have to upload the finished xpi to mozilla.

reesericci commented 3 years ago

whoops i forgot that you upload a zip to amo not an xpi

deepjyoti30 commented 3 years ago

@reesericci I think though that a zip can be built using GitHub Actions, sounds like a good option.

deepjyoti30 commented 3 years ago

@reesericci I think the zip I was providing with each release is not important anymore since it can be directly installed by cloning the repo.

I'll update the installation instructions and move to download latest release source zip rather than attaching a build during release.

reesericci commented 3 years ago

@reesericci I think the zip I was providing with each release is not important anymore since it can be directly installed by cloning the repo.

I'll update the installation instructions and move to download latest release source zip rather than attaching a build during release.

just make sure it has the manifest.json so we don't have issue #34 come up again.

deepjyoti30 commented 3 years ago

@reesericci As in the latest release, I have not added any custom zip. It's just the one provided by GitHub which has the source code as of the release date. That one surely contains the mainfest.json file because the source contains it, so should be cool!