deepjyoti30 / ytmdl

A simple app to get songs from YouTube in mp3 format with artist name, album name etc from sources like iTunes, Spotify, LastFM, Deezer, Gaana etc.
https://ytmdl.deepjyoti30.dev
MIT License
3.22k stars 164 forks source link

Zombie files buildup #284

Open hariprasanths opened 1 year ago

hariprasanths commented 1 year ago

Bug report

Checklist

Version Info

How Ytmdl was installed?

pip

Console Log

Ignoring error:  [Errno 24] Too many open files

Description

I am getting the following error when trying to download a playlist with 600+ songs: [Errno 24] Too many open files

Default limit in my distro for simulatenous open files seems to be 1024, fetched via ulimit -n

Following are some the places where I think the files aren't closed: download archive file, song's cache file, artwork file

Can be reproed everytime a big playlist is downloaded

deepjyoti30 commented 1 year ago

@hariprasanths If possible can you share the playlist link or any similar playlist that you were able to reproduce the issue with?

Following are some the places where I think the files aren't closed: download archive file, song's cache file, artwork file

Do you have any reason to think these are the places where the issue is occurring?

Also, please share the exact ytmdl command you are using so it's possible for me to debug this.