deepjyoti30 / ytmdl

A simple app to get songs from YouTube in mp3 format with artist name, album name etc from sources like iTunes, Spotify, LastFM, Deezer, Gaana etc.
https://ytmdl.deepjyoti30.dev
MIT License
3.22k stars 164 forks source link

[FEATURE REQUEST] Consider dropping/replacing ffmpeg-python dependency because of future transitive dependency #292

Open xgqt opened 10 months ago

xgqt commented 10 months ago

Feature Request

Checklist

Description

Please consider dropping ffmpeg-python depending on the future library.

There is a fix to patch ffmpeg-python to remove the dependency but the repo did not see any PR merged since 2022, so I am sceptic that it will receive the fix.

See also: https://github.com/kkroening/ffmpeg-python/pull/795

Citing the Gentoo bugreport for future:

Unmaintained with last release in 2019.  We already patched it to work
with Python 3.9+.  The upstream code is also vulnerable
to CVE-2022-40899.  Above all, this library is completely redundant
to packages not supporting Python 2 anymore.

Please see: https://bugs.gentoo.org/888271

deepjyoti30 commented 10 months ago

@xgqt Thanks for the request. If I have to drop ffmpeg-python, I will have to check for some alternative that I can use in it's place.

Seems like the package was abandoned a while back. Will have to look for some fork of it that can be used as a possible alternative.

xgqt commented 10 months ago

This one looks ok, they even have almost identical example in the README: https://github.com/jonghwanhyeon/python-ffmpeg

There are also:

emilazy commented 4 months ago

You may also want to consider https://github.com/PyAV-Org/PyAV.