HttpAccessDeniedError error.message not available in httpWorkflow.onAccessDenied.event

[colorcube]

Sending custom error messages seems not to be easy:

    @eventDispatcher.listen(httpWorkflow.onAccessDenied)
    async onAccessDenied(event: typeof httpWorkflow.onAccessDenied.event) {
        event.send(new HtmlResponse(event.error.message || 'Access denied', 403));
    }

event.error.message is not available there - at least I haven't found the exception message

That means in http controller it's not possible to send custom messages like

throw new HttpAccessDeniedError('my custom "Access denied" message');

in controller something like that is possible get the message out but that's not very sexy

        } catch (e) {
            if (e instanceof HttpAccessDeniedError) {
                response.setHeader('X-Reason', e.message || 'unknown');
            }
            throw e;
        }

[colorcube]

I guess this is the code to be changed:

if (error instanceof HttpAccessDeniedError) {
    event.next('accessDenied', new HttpAccessDeniedEvent(event.injectorContext, event.request, event.response, event.route));
} else {
    const errorEvent = new HttpControllerErrorEvent(event.injectorContext, event.request, event.response, event.route, error);
    errorEvent.controllerActionTime = Date.now() - start;
    event.next('controllerError', errorEvent);
}

adding error to HttpAccessDeniedEvent ?!

[marcj]

adding error to HttpAccessDeniedEvent ?!

yes, we can do that

[marcj]

@colorcube added in https://github.com/deepkit/deepkit-framework/commit/53ffb33d5e775067dac34a9146c901d3cbd13acd. Please test and let me know. Thanks

[colorcube]

It works for me. Thanks