search

deeplook / svglib

Read SVG files and convert them to other formats.
GNU Lesser General Public License v3.0
315 stars 80 forks source link

Fix AppVeyor build #198

Closed nicoddemus closed 5 years ago

nicoddemus commented 5 years ago

Fix #197

nicoddemus commented 5 years ago

@deeplook ready for review. 👍

I'm watching the repository to keep a watch over the Windows builds, but if any of them fails for reasons which are not code related please don't hesitate in pinging me.

deeplook commented 5 years ago

That would switch from Python 3.6 only to 3.7 only, right? Just nosey: is there a reason for not testing both?

nicoddemus commented 5 years ago

That would switch from Python 3.6 only to 3.7 only, right? Just nosey: is there a reason for not testing both?

No, the interpreter invoking tox is not necessarily the same which will be created by tox and be used to run the commands. This can be verified by the pytest banner:

py27

============================= test session starts =============================
platform win32 -- Python 2.7.16, pytest-4.6.4, py-1.8.0, pluggy-0.12.0

py35

============================= test session starts =============================
platform win32 -- Python 3.5.4, pytest-5.0.0, py-1.8.0, pluggy-0.12.0

And so on.

That's why on Linux it is perfectly OK and common to execute python3 -m tox -e py27 to execute the tests under Python 2, even though you are executing tox through Python 3.