search

deeplook / svglib

Read SVG files and convert them to other formats.
GNU Lesser General Public License v3.0
322 stars 79 forks source link

Remove Python2 numerical relics and fix % formatting in logging #269

Closed eumiro closed 3 years ago

deeplook commented 3 years ago

Thanks! LGTM! Just nosey, did you run a tool for spotting the ints/floats? If so which one?

eumiro commented 3 years ago

I just sought for int, float, looked at the literal numerals and watched my GeoPython 2021 talk :-)

Looks like you'll need to set the environment for Python 3.9 in AppVeyor to run it correctly. See https://www.appveyor.com/docs/windows-images-software/#python for different Visual Studio versions.

deeplook commented 3 years ago

Frankly, I don't see how to add a py39 environment for AppVeyor: https://ci.appveyor.com/project/deeplook/svglib. Maybe it's time to move to https://docs.github.com/en/actions/guides/building-and-testing-python?

eumiro commented 3 years ago

Frankly, I don't see how to add a py39 environment for AppVeyor: https://ci.appveyor.com/project/deeplook/svglib. Maybe it's time to move to https://docs.github.com/en/actions/guides/building-and-testing-python?

Right, let's do it in #271

eumiro commented 3 years ago

Rebased onto GHA/Travis/Appveyor changes, so the Python versions migration touches PyPI classifiers only. The removal of Python2 int/float relics and proper % log formatting have not been touched.

deeplook commented 3 years ago

I have now deleted this project from https://ci.appveyor.com/account/deeplook/projects.