Add streamlit demo - Githubissues

deeplook / svglib

Read SVG files and convert them to other formats.

GNU Lesser General Public License v3.0

315 stars 80 forks source link

Add streamlit demo #270

Closed deeplook closed 3 years ago

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 2eb3ea8a42364afe63f48881a1fb0a32ef9c7abf into 21f3deb5f63fdbc021131af7a815c311a732a739 - view on LGTM.com

new alerts:

1 for Unused import
1 for Insecure temporary file

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 5f9cb7d1795c768a19de45029d5e4506e8083810 into 21f3deb5f63fdbc021131af7a815c311a732a739 - view on LGTM.com

new alerts:

1 for Insecure temporary file

claudep commented 3 years ago

Did you really meant to commit that .mov video? I'm a bit worried on two things:

distribution: do we want to distribute a video when people install svglib? I fear it's a bit wasted space for most people.
the .mov format is not the best supported, cross-platform-wise.

What about uploading that video on some video hosting infrastructure instead, and then link to it somewhere, maybe in the README?

deeplook commented 3 years ago

I understand your concerns, especially when adding more demos like this in the future. OTOH, it's "distributed" only when you clone the repo, not when you pip install it, and it's 1 Mb only. I've sticked with .mov (generated by Streamlit) because GitHub renders it when linked from a MD/ReST page, and has better controls than a GIF (mainly full screen and audio). GIFs also get pretty big the larger the image dimensions are and the more the content changes. But if you know of a reliable, dedicated external service, that doesn't spam readers with ads, please let me know.

claudep commented 3 years ago

You could try to host it on a PeerTube instance, e.g. https://peertube.linuxrocks.online.