Fix files not closed in setup.py

deeplook / svglib

Read SVG files and convert them to other formats.

GNU Lesser General Public License v3.0

324 stars 79 forks source link

Fix files not closed in setup.py #293

Closed victorbnl closed 3 years ago

victorbnl commented 3 years ago

Files in Python should be open using

with open('file', 'r') as f:
    f.read()

and not

open('file').read()

claudep commented 3 years ago

That's true, however we might also solve this by using a setup.cfg file, which is a more modern and clean approach. Would you like to try that?

victorbnl commented 3 years ago

Oh I didn't know it was more modern, then I'm going to use that in my projects! I'm closing this PR as it's not related anymore and making the changes to a setup.cfg in another one.