deeplook / svglib

Read SVG files and convert them to other formats.
GNU Lesser General Public License v3.0
325 stars 79 forks source link

Use a setup.cfg #294

Closed victorbnl closed 3 years ago

victorbnl commented 3 years ago

Discussions about the future PR using setup.cfg

victorbnl commented 3 years ago

So, there will be a problem with the lines

needs_pytest = {'pytest', 'test', 'ptr'}.intersection(sys.argv)
pytest_runner = ['pytest-runner'] if needs_pytest else []
setup_requires=[] + pytest_runner,
victorbnl commented 3 years ago

Also I think I impletement directly #165? As it works and using console scripts is the right way to do what we want

victorbnl commented 3 years ago

So, there will be a problem with the lines

needs_pytest = {'pytest', 'test', 'ptr'}.intersection(sys.argv)
pytest_runner = ['pytest-runner'] if needs_pytest else []
setup_requires=[] + pytest_runner,

Or maybe I still keep setup.py with only

import sys
from setuptools import setup

install_requires = open('requirements.txt').read().strip().split()

needs_pytest = {'pytest', 'test', 'ptr'}.intersection(sys.argv)
pytest_runner = ['pytest-runner'] if needs_pytest else []

setup(
    install_requires=install_requires,
    setup_requires=[] + pytest_runner,
    data_files=[('share/man/man1', ['svg2pdf.1'])],
)

For the dynamic things? I don't really know how having both files works so I don't know if I can do so