search

deeplook / svglib

Read SVG files and convert them to other formats.
GNU Lesser General Public License v3.0
311 stars 80 forks source link

Migrating to setup.cfg #295

Closed victorbnl closed 2 years ago

victorbnl commented 2 years ago

Closes #294

claudep commented 2 years ago

That looks nice. Would be great if you can test that on various platforms. @deeplook, what do you think?

deeplook commented 2 years ago

Nice and simple and great! Thanks!!

victorbnl commented 2 years ago

That looks nice. Would be great if you can test that on various platforms. @deeplook, what do you think?

If you want I can run the GitHub Actions workflow locally, if it's up-to-date, would it help?

deeplook commented 2 years ago

Something is wrong with the builds on GitHub CI. Any idea? @victorbnl, @claudep

claudep commented 2 years ago

It looks like some flag download failed. I committed dac1ddce4 so as we get better error reporting, to know if it's always the same flag failing or random failures.

deeplook commented 2 years ago

If it's really a flag my bet is on Afghanistan...

claudep commented 2 years ago

:face_with_head_bandage:

victorbnl commented 2 years ago

Did you mean rebasing for not having these two commits above? Or when merging the PR?

claudep commented 2 years ago

I asked the rebase because I committed a tweak to be able to know which flag is failing to download in the test suite.

claudep commented 2 years ago

@deeplook was right about the Afghanistan flag! Anyway, this has nothing to do with this patch, we can go ahead.

deeplook commented 2 years ago

Using better tooling like in https://github.com/deeplook/svglib/pull/296 will make this type of contributions hopefully superfluous. ;)