Closed victorbnl closed 2 years ago
That looks nice. Would be great if you can test that on various platforms. @deeplook, what do you think?
Nice and simple and great! Thanks!!
That looks nice. Would be great if you can test that on various platforms. @deeplook, what do you think?
If you want I can run the GitHub Actions workflow locally, if it's up-to-date, would it help?
Something is wrong with the builds on GitHub CI. Any idea? @victorbnl, @claudep
It looks like some flag download failed. I committed dac1ddce4 so as we get better error reporting, to know if it's always the same flag failing or random failures.
If it's really a flag my bet is on Afghanistan...
:face_with_head_bandage:
Did you mean rebasing for not having these two commits above? Or when merging the PR?
I asked the rebase because I committed a tweak to be able to know which flag is failing to download in the test suite.
@deeplook was right about the Afghanistan flag! Anyway, this has nothing to do with this patch, we can go ahead.
Using better tooling like in https://github.com/deeplook/svglib/pull/296 will make this type of contributions hopefully superfluous. ;)
Closes #294