Closed djhoese closed 4 years ago
I just sent a PR to @djhoese to update his branch. That PR includes some updates to setup.py to actually list the minimal dependencies, and associated doc fixes. I also tested this PR against the included dataset, and everything works just fine (once I fixed my outdated test runner). So, with those updates this PR LGTM.
@deeplycloudy You should be able to push commits directly to my branch on my fork (because I made this PR). Do you want to try that instead of making a separate PR? Or are you concerned/unsure of the changes you've made?
@djhoese ah, had to teach myself how to do that, but that's been sorted out.
As discussed in https://github.com/deeplycloudy/glmtools/pull/56, lmatools depends on six but doesn't list it as a dependency. The package could either list this as a dependency in setup.py or it could drop
six
as a dependency which means python 2 support is also dropped. This PR does the latter.This was pretty easy to accomplish and in general includes three types of changes:
range
,map
, andzip
which were being used for getting an iterator instead of a list like python 2's version of these functions.iteritems
to get the iterator version ofmy_dict.items()
by doingiteritems(my_dict)
. In python 3 the first form is an iterator.next
function which only exists in python 2 as amy_iter.next()
method, if I remember correctly. This is the only change that should make the code non-py2 compatibie.