search

deeplycloudy / xlma-python

A future, Python-based version of xlma?
MIT License
6 stars 6 forks source link

Improve color_by_time #35

Closed wx4stg closed 5 months ago

wx4stg commented 5 months ago

This allows for coloring numpy datetime64[ns] (used by event_time and flash_time_start) and even regular floats. tlim is now an optional kwarg, if it is not provided, it is assumed that the min and max of the time_array are the upper and lower bounds for tlim

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@f0bb273). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #35 +/- ## ========================================= Coverage ? 76.61% ========================================= Files ? 12 Lines ? 1732 Branches ? 0 ========================================= Hits ? 1327 Misses ? 405 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deeplycloudy commented 5 months ago

This moves us away from the python datetime API, and toward numpy's datetime64, which I like as a time format to which we promote all datasets. Tests, etc. LGTM. Thanks for not breaking earlier compatibility.