deeplycloudy / xlma-python

A future, Python-based version of xlma?
MIT License
6 stars 6 forks source link

LMA Intercept RHI #38

Closed wx4stg closed 3 months ago

wx4stg commented 3 months ago

Performs coordinate transformations for LMA plotting source locations along a radar RHI (range from radar, distance from plane of scan, height above ground)

This is mostly (~90%) a reimplementation of Souza & Bruning 2021

This is a draft (for now), I need to add tests, better docs, and hopefully remove the dependency on py-ART (which would allow for manually specifying an azimuth, time, rangemax, etc. Useful if you have a volume ppi scan and want to make psuedo-RHIs, as well as other 'creative' uses, possibly involving aircraft radars)

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.45%. Comparing base (e9fc3ba) to head (4c242be).

Files Patch % Lines
pyxlma/lmalib/lma_intercept_rhi.py 97.18% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #38 +/- ## ========================================== + Coverage 76.64% 77.45% +0.80% ========================================== Files 12 13 +1 Lines 1734 1805 +71 ========================================== + Hits 1329 1398 +69 - Misses 405 407 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deeplycloudy commented 3 months ago

Just visited in person with @wx4stg with a few clarification comments on use, as in the most recent commit. Merging.