search

deeplycloudy / xlma-python

A future, Python-based version of xlma?
MIT License
6 stars 6 forks source link

GLM plotting does not filter by time bounds #50

Open wx4stg opened 2 months ago

wx4stg commented 2 months ago

I'm not really sure what the default behaviour "should" be here, but when plotting GLM events on an already existing xlma BlankPlot, the GLM events are plotted on the plan and cross sectional axes regardless of whether or not the events fall in the timeframe specified by the BlankPlot's tlim

deeplycloudy commented 2 months ago

I believe the way I handled this in the draft implementation was to have a filtering function that was called as part of a custom subclass in the notebook. So those subsetting functions exist and can get rolled into an if has_glm: part of the default interactive class. Maybe blank_plot can call the same subsetting logic for the static plot.