Library completely broken since 0.10.0 on some devices

[alaegin]

Hello! We have just started to use this library and realized that it's completely broken on some devices since 0.10.0.

Prerequisites:

• CameraView library for video recording. Default settings with Camera2 Engine.
• OnePlus 5 and OnePlus 7 Pro. Both use Android 10. (Also tested on Honor 9X (STK-LX1) and it works fine there).

The main problem is that the library crashes unexpectedly in some cases or transcode video with artifacts.

• 0.9.1 works fine
• 0.10.0 - 0.10.2 print Validator has decided that the input is fine and transcoding is not necessary. and don't transcode video at all. Link
• 0.10.3 fails with several random issues listed below

We have several cases:

1. Library crashes with exception java.lang.IllegalStateException: Failed to stop the muxer. Link
2. Library crashes with exception TranscodeEngine: Unexpected error while transcoding. java.nio.BufferOverflowException. Link
3. Library transcode video with artifacts. Link to video

The code we use to call Transcoder:

Transcoder.into(filesProvider.getTempResultFile().absolutePath)
    .apply {
        files.forEach { addDataSource(it.absolutePath) }
    }
    .setListener(...)
    .transcode().get()

It seems that rewriting #118 of the transcoder pipeline broke something important.

[natario1]

Can you provide the media files to reproduce these issues in the demo app?

[alaegin]

Videos that were converted with artifacts on OnePlus phones but without them on the android emulator: Part #1 Part #2

Videos from OnePlus 5 Part #1 Part #2

[jumperson]

Library transcode video with artifacts. Link to video

I have same issue in below devices.

• F-02L (OS: 9)
• Lenovo Tab P11 Pro (OS: 10)

[natario1]

IMO these issues should be fixed by latest PRs - #159, #200, #201 . Another issue that remains related to buffer overflow is tracked at #163 .