deepmodeling / abacus-develop

An electronic structure package based on either plane wave basis or numerical atomic orbitals.
http://abacus.ustc.edu.cn
GNU Lesser General Public License v3.0
174 stars 136 forks source link

Update CMakeLists.txt to match version in source/version.h #3729

Closed Cstandardlib closed 8 months ago

Cstandardlib commented 8 months ago

Describe the Code Quality Issue

In the latest version (v3.5.4) of ABACUS, there is a discrepancy in the version numbers. Specifically, the CMakeLists.txt file sets the version number to v3.0.0, while the actual version number is correctly defined as v3.5.4 in the source/version.h file. This inconsistency may lead to confusion and should be addressed to maintain code quality.

Additional Context

In source/module_io/parse_args.h, function parse_args returns the version information when using command "abacus --version", "abacus -v" or "abacus -V". This function prints the correct version (v3.5.4) while CMakeLists.txt file sets the version number to v3.0.0, which is confusing.

Task list for Issue attackers (only for developers)

WHUweiqingzhou commented 8 months ago

Thanks for your suggestion! We will fix it.