deepmodeling / abacus-develop

An electronic structure package based on either plane wave basis or numerical atomic orbitals.
http://abacus.ustc.edu.cn
GNU Lesser General Public License v3.0
174 stars 136 forks source link

Refactor: remove the redundant macro in source file of VDW module #5562

Closed kirk0830 closed 13 hours ago

kirk0830 commented 1 day ago

What's changed?

After the PR#5517, all free functions defined in header files are moved into source file to avoid voilating the One Definition Rule (ODR). However, there is a macro previously defined is not removed. Although it will not affect anything (due to the source file only needs to be compiled for once), it is better to remove it for a correct programming habit.