Closed saltball closed 2 years ago
Thank you for your detailed suggestion. We have made two kanbans about APIs and tests.
Reader
, NetCorr
and Penalty
, although these classes may seem unclear how to extended them. We will do some developer doc to improve this.p.s. I will rewrite this issue into several smaller ones and relate them with the kanbans tomorrow.
I notice deepks-kit manifesto from zhihu.com and deepmd Wechat Official Accounts, also
The DeepModeling Manifesto
. I hope I can do something.This repo has few infomation about develop of deepks-kit, so is there any detail planning for deepks-kit, such as:
Actually I think
dplibrary
is one good platform for data sharing, so will there be any API for users to directly download the data, model from dplibrary? Or deepks-kit will use another work flow?In
readme.md
, there are TODO section which mentions four items to do. I offer some suggests for the second one "Rewrite all print function using logging":I think in here
logging
refers to python standard librarylogging
. And according to the library using command line mostly, we can set logging in one log.py file. Here I have two methods:setup
function like (https://github.com/sehoonha/pydart2/blob/master/pydart2/utils/log.py);Logger
fromlogging.logger
like:from.util.config import getGlobValue # get global variable
all = [ "InfoLogger", "Logger" ]
""" Predefined Loggers for project. Usage:
"""
class BaseLogging(logging.Logger): def init(self, name, level=logging.INFO, file=None, console_on=False): """
class InfoLogger(BaseLogging): """ Default Logger to console with INFO level. Set file to a real file to log in file. Parameters
class DebugLogger(BaseLogging): """ Default Logger to console with DEBUG level. Set file to a real file to log in file. Parameters
def getLogger(level=logging.DEBUG): """ Generate a logger with level. Parameters
Logger = getLogger(level=getGlobValue("log_level"))