search

deepmodeling / deepmd-kit

A deep learning package for many-body potential energy representation and molecular dynamics
https://docs.deepmodeling.com/projects/deepmd/
GNU Lesser General Public License v3.0
1.41k stars 487 forks source link

tests: skip attention-related parameterize when attn_layer is 0 #3784

Closed njzjz closed 2 months ago

njzjz commented 2 months ago

The tests make no sense in this case.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The `test_dpa1.py` file has been updated to enhance its testing functionality by introducing an optional `temperature` parameter to the `is_meaningless_zero_attention_layer_tests` method. Additionally, the `skip_pt`, `skip_dp`, and `skip_tf` methods have been modified to incorporate this new parameter, ensuring more comprehensive and customizable testing scenarios. ## Changes | File | Change Summary | |-------------------------------------------|-----------------------------------------------------------------------------------------------------| | `source/tests/consistent/descriptor/...` | Added an `Optional[float]` parameter `temperature` to `is_meaningless_zero_attention_layer_tests`. | | `source/tests/consistent/descriptor/...` | Updated `skip_pt`, `skip_dp`, and `skip_tf` methods to call `is_meaningless_zero_attention_layer_tests` with specific parameters. |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 2bf07698a878e967adcfce858e92e5a3c496e734 and aeaeff2d3fba562f5d2bde489939505856367909.
Files selected for processing (1) * source/tests/consistent/descriptor/test_dpa1.py (5 hunks)
Additional comments not posted (4)
source/tests/consistent/descriptor/test_dpa1.py (4)
`111-118`: The changes to the `is_meaningless_zero_attention_layer_tests` method look good. The logic correctly checks if the `attn_layer` is zero and any of the other conditions are true. --- `141-146`: The changes to the `skip_pt` property look good. The method call to `is_meaningless_zero_attention_layer_tests` with the specific parameters is correctly implemented. --- `169-174`: The changes to the `skip_dp` property look good. The method call to `is_meaningless_zero_attention_layer_tests` with the specific parameters is correctly implemented. --- `199-213`: The changes to the `skip_tf` property look good. The method call to `is_meaningless_zero_attention_layer_tests` with the specific parameters is correctly implemented.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.49%. Comparing base (2bf0769) to head (aeaeff2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3784 +/- ## ======================================= Coverage 82.49% 82.49% ======================================= Files 515 515 Lines 48642 48642 Branches 2980 2980 ======================================= Hits 40126 40126 Misses 7605 7605 Partials 911 911 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.