Closed njzjz closed 1 month ago
[!WARNING]
Rate Limit Exceeded
@njzjz has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 16 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between c7d560f13d3a264b04f7cb99ffdff69dd8c7f9fe and fa8b2a61d29024e8356583618de8d7ce306a5fbd.
The changes involve the removal of the j_must_have
function from various files in the deepmd
project and replacing its usage with direct dictionary access. Additionally, the j_must_have
function has been renamed to j_deprecated
in deepmd/common.py
, with updated parameter names and an optional deprecated_key
parameter to issue warnings for deprecated keys.
File(s) | Change Summary |
---|---|
deepmd/common.py |
Removed j_must_have function, renamed it to j_deprecated with updated parameters and added an optional deprecated_key . |
deepmd/tf/common.py |
Removed j_must_have from the list of exported entities. |
deepmd/tf/entrypoints/train.py , deepmd/tf/train/trainer.py |
Removed j_must_have function calls and directly accessed dictionary keys. |
deepmd/utils/compat.py , deepmd/utils/data_system.py |
Replaced j_must_have with j_deprecated and updated direct dictionary key access. |
source/tests/tf/... |
Removed j_must_have imports and calls, replaced with direct dictionary key access in multiple test files. |
Objective (Issue #3523) | Addressed | Explanation |
---|---|---|
Rename j_must_have to j_deprecated and update parameters |
✅ | |
Add optional deprecated_key parameter to j_deprecated |
✅ | |
Remove j_must_have usage and replace with direct dictionary access |
✅ |
The changes meet the primary objectives of renaming the j_must_have
function to j_deprecated
, adding an optional deprecated_key
parameter, and updating the codebase to remove j_must_have
usage in favor of direct dictionary access.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.48%. Comparing base (
7b16911
) to head (fa8b2a6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@coderabbitai resolve
Fix #3523.
Summary by CodeRabbit
Refactor
j_must_have
function and directly accessing dictionary keys in various test files.j_must_have
with direct dictionary access for improved code readability and maintenance.Chores