search

deepmodeling / deepmd-kit

A deep learning package for many-body potential energy representation and molecular dynamics
https://docs.deepmodeling.com/projects/deepmd/
GNU Lesser General Public License v3.0
1.41k stars 486 forks source link

chore(ci): workaround to retry `error decoding response body` from uv #3889

Closed njzjz closed 1 week ago

njzjz commented 2 weeks ago

This PR uses a shell wrapper to check if the error decoding response body error message is in the uv stderr and retry if so. It is just a workaround for https://github.com/astral-sh/uv/issues/2586 and https://github.com/astral-sh/uv/issues/3514 and hope the upstream can fix it.

Note that this PR does nothing with cibuildwheel. It's unclear how to retry with certain errors under its complex logic (feature requested in https://github.com/pypa/cibuildwheel/issues/1846).

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The recent updates standardize the installation process for dependencies like TensorFlow, Torch, and mpi4py across several GitHub workflow files. The key change involves replacing python -m uv pip install with a new script, uv_with_retry.sh, which includes a retry mechanism to handle installation errors more robustly. This ensures consistent and reliable installations during the build and testing phases for various configurations.

Changes

Files/Paths Change Summary
.github/workflows/build_cc.yml Updated installation commands to use source/install/uv_with_retry.sh for TensorFlow and other dependencies.
.github/workflows/test_cc.yml Standardized installation commands using source/install/uv_with_retry.sh.
.github/workflows/test_cuda.yml Modified installation commands to implement uv_with_retry.sh script for TensorFlow, Torch, and mpi4py.
.github/workflows/test_python.yml Revised installation process for mpich, torch, horovod, and mpi4py to utilize source/install/uv_with_retry.sh.
source/install/uv_with_retry.sh Introduced a script that retries the uv command up to 3 times on encountering the "error decoding response body" error.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI/CD Pipeline
    participant UV_with_retry.sh
    participant Dependency Server

    Developer->>CI/CD Pipeline: Triggers workflow
    CI/CD Pipeline->>UV_with_retry.sh: Run install command
    UV_with_retry.sh->>Dependency Server: Attempt to install dependency
    Dependency Server-->>UV_with_retry.sh: Error response (if any)
    UV_with_retry.sh->>UV_with_retry.sh: Retries up to 3 times on error
    UV_with_retry.sh-->>CI/CD Pipeline: Returns success/failure
    CI/CD Pipeline-->>Developer: Reports build/test result

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.74%. Comparing base (0c472d1) to head (facf45b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #3889 +/- ## ======================================= Coverage 82.74% 82.74% ======================================= Files 518 518 Lines 50215 50215 Branches 2978 2982 +4 ======================================= Hits 41548 41548 Misses 7757 7757 Partials 910 910 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.