coderabbitai[bot]
commented
2 weeks ago Walkthrough
## Walkthrough The main change involves updating the method for retrieving the PyTorch library path in the `CMakeLists.txt` file. Instead of directly setting the path using hardcoded variables, the new approach leverages the `get_target_property` and `get_filename_component` commands. This potentially enhances the flexibility and accuracy of the build configuration process for PyTorch. ## Changes | File | Change Summary | |-----------------------------|------------------------------------------------------------------------------------------------------------| | source/CMakeLists.txt | Updated the retrieval of the PyTorch library path using `get_target_property` and `get_filename_component` instead of directly setting it. |Recent review details
**Configuration used: CodeRabbit UI** **Review profile: CHILL**Commits
Files that changed from the base of the PR and between 0c472d1596ae24b5b548ae6ae38688dbab911de5 and 6d150abb28ba46a815aeb047deda30f14ec0f3a3.Files selected for processing (1)
* source/CMakeLists.txt (1 hunks)Additional comments not posted (1)
source/CMakeLists.txt (1)
`203-204`: The changes to how `PyTorch_LIBRARY_PATH` is determined are an improvement, enhancing flexibility and accuracy in locating the library.Verification successful
--- The new method for setting `PyTorch_LIBRARY_PATH` appears to be integrated correctly within the `BACKEND_LIBRARY_PATH` usage across various CMake configuration files. This change enhances the build system's flexibility and accuracy in locating the PyTorch library without causing any unintended side effects. - `source/CMakeLists.txt`: The new method directly affects `BACKEND_LIBRARY_PATH`, which is consistently used across multiple CMakeLists.txt files to set `INSTALL_RPATH`.Scripts executed
The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Description: Verify if the new method for setting PyTorch_LIBRARY_PATH affects other configurations. # Test: Search for usages of `PyTorch_LIBRARY_PATH`. Expect: No unexpected references or configurations. rg --type cmake $'PyTorch_LIBRARY_PATH' --files-with-matches ``` Length of output: 81 --- --- Script: ```shell #!/bin/bash # Extract lines containing `PyTorch_LIBRARY_PATH` from `source/CMakeLists.txt` for detailed review rg --type cmake 'PyTorch_LIBRARY_PATH' source/CMakeLists.txt ``` Length of output: 196 --- --- Script: ```shell #!/bin/bash # Search for usages of `BACKEND_LIBRARY_PATH` within CMake configuration files to ensure correct usage rg --type cmake 'BACKEND_LIBRARY_PATH' ``` Length of output: 1381
The previous
PyTorch_LIBRARY_PATHin #3636 is wrong:BACKEND_INCLUDE_DIRSis a list of paths instead of a single path.Summary by CodeRabbit