deepmodeling / dpdata

A Python package for manipulating atomistic data of software in computational science
https://docs.deepmodeling.com/projects/dpdata/
GNU Lesser General Public License v3.0
195 stars 129 forks source link

fix psi4 length conversion #571

Closed njzjz closed 11 months ago

njzjz commented 11 months ago

The length conversion in Psi4 is not fixed to Bohr. Instead, the output unit follows the input unit and is written in the output file.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f2d09a5) 82.84% compared to head (b26006a) 82.86%. Report is 2 commits behind head on devel.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #571 +/- ## ========================================== + Coverage 82.84% 82.86% +0.02% ========================================== Files 74 74 Lines 6591 6600 +9 ========================================== + Hits 5460 5469 +9 Misses 1131 1131 ``` | [Files](https://app.codecov.io/gh/deepmodeling/dpdata/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deepmodeling) | Coverage Δ | | |---|---|---| | [dpdata/plugins/psi4.py](https://app.codecov.io/gh/deepmodeling/dpdata/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deepmodeling#diff-ZHBkYXRhL3BsdWdpbnMvcHNpNC5weQ==) | `100.00% <100.00%> (ø)` | | | [dpdata/psi4/output.py](https://app.codecov.io/gh/deepmodeling/dpdata/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deepmodeling#diff-ZHBkYXRhL3BzaTQvb3V0cHV0LnB5) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/deepmodeling/dpdata/pull/571/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deepmodeling)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.