Closed MoseyQAQ closed 3 months ago
Attention: Patch coverage is 88.23529%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 83.67%. Comparing base (
3869146
) to head (9928e1c
).
Files | Patch % | Lines |
---|---|---|
dpdata/pymatgen/structure.py | 85.71% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now the PyMatgenStructureFormat doesn't support the from_system method. This PR adds this method, enabling users to convert the pymatgen.core.Structure to the dpdata format, which is convenient when you use pymatgen.transformations to build the atomic model.