deepmodeling / dpdata

Manipulating multiple atomic simulation data formats, including DeePMD-kit, VASP, LAMMPS, ABACUS, etc.
https://docs.deepmodeling.com/projects/dpdata/
GNU Lesser General Public License v3.0
188 stars 128 forks source link

fix: fix invalid escape sequence #647

Closed njzjz closed 2 months ago

njzjz commented 2 months ago

Fix the warning below:

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:6
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:6: DeprecationWarning: invalid escape sequence '\|'
    latt_patt = "\|\s+([0-9]{1,}[.][0-9]*)\s+([0-9]{1,}[.][0-9]*)\s+([0-9]{1,}[.][0-9]*)"

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:7
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:7: DeprecationWarning: invalid escape sequence '\|'
    pos_patt_first = "\|\s+[0-9]{1,}[:]\s\w+\s(\w+)(\s.*[-]?[0-9]{1,}[.][0-9]*)(\s+[-]?[0-9]{1,}[.][0-9]*)(\s+[-]?[0-9]{1,}[.][0-9]*)"

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:8
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:8: DeprecationWarning: invalid escape sequence '\s'
    pos_patt_other = "\s+[a][t][o][m]\s+([-]?[0-9]{1,}[.][0-9]*)\s+([-]?[0-9]{1,}[.][0-9]*)\s+([-]?[0-9]{1,}[.][0-9]*)\s+(\w{1,2})"

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:9
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:9: DeprecationWarning: invalid escape sequence '\|'
    force_patt = "\|\s+[0-9]{1,}\s+([-]?[0-9]{1,}[.][0-9]*[E][+-][0-9]{1,})\s+([-]?[0-9]{1,}[.][0-9]*[E][+-][0-9]{1,})\s+([-]?[0-9]{1,}[.][0-9]*[E][+-][0-9]{1,})"

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:10
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/fhi_aims/output.py:10: DeprecationWarning: invalid escape sequence '\s'
    eng_patt = "Total energy uncorrected.*([-]?[0-9]{1,}[.][0-9]*[E][+-][0-9]{1,})\s+eV"

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/abacus/scf.py:41
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/abacus/scf.py:41: DeprecationWarning: invalid escape sequence '\s'
    while len(re.split("\s+", lines[blk_idx])) == 0:

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/abacus/scf.py:44
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/abacus/scf.py:44: DeprecationWarning: invalid escape sequence '\s'
    if len(re.split("\s+", lines[blk_idx])) == 0 or lines[blk_idx] == "":

../../../../../opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/abacus/scf.py:332
  /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dpdata/abacus/scf.py:332: DeprecationWarning: invalid escape sequence '\s'
    if len(re.split("\s+", geometry_inlines[iline])) >= 3:
coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The modifications involve updating regular expression patterns across two Python files by introducing raw string literals. This change enhances the accuracy of pattern matching operations within functions that process text data. The adjustment ensures that special characters in regular expressions are interpreted correctly, improving the reliability of data parsing in the codebase. ## Changes | File Path | Change Summary | |----------------------------|----------------| | `dpdata/.../scf.py` | Updated regular expression patterns in functions `get_block` and `get_nele_from_stru` to use raw string literals for better pattern matching. | | `dpdata/.../output.py` | Added raw string (`r`) prefixes to regular expression patterns used in lattice, position, force, and energy calculations. |

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f69f6d4ab312b37b826a64ecc3881dc9e04e473d and 7a4ec3610d2b540f4c0f2e0c2ef73892c93ddf00.
Files selected for processing (2) * dpdata/abacus/scf.py (2 hunks) * dpdata/fhi_aims/output.py (1 hunks)
Files skipped from review due to trivial changes (1) * dpdata/fhi_aims/output.py
Additional Context Used
Ruff (7)
dpdata/abacus/scf.py (7)
26-26: Use format specifiers instead of percent format --- 94-94: Use format specifiers instead of percent format --- 134-134: Use format specifiers instead of percent format --- 370-370: Use format specifiers instead of percent format --- 374-374: Use format specifiers instead of percent format --- 383-383: Use format specifiers instead of percent format --- 388-388: Use format specifiers instead of percent format
Additional comments not posted (3)
dpdata/abacus/scf.py (3)
`41-41`: Correctly updated regular expression to raw string format. --- `44-44`: Correctly updated regular expression to raw string format. --- `332-332`: Correctly updated regular expression to raw string format.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.67%. Comparing base (f69f6d4) to head (7a4ec36).

Files Patch % Lines
dpdata/abacus/scf.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #647 +/- ## ======================================= Coverage 83.67% 83.67% ======================================= Files 80 80 Lines 7006 7006 ======================================= Hits 5862 5862 Misses 1144 1144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.