Closed njzjz closed 4 months ago
The recent changes across the codebase focus on enhancing code readability, maintainability, and functionality. Updates include transitioning to f-strings for improved string formatting, updating dependencies in configuration files, refining GitHub Actions workflows, and introducing new functionalities like metadata files and test cases. Certain files have been restructured or added to support emerging features and testing requirements.
File(s) | Change Summary |
---|---|
.git_archival.txt , .gitattributes |
Introduced metadata file and export configuration. |
.github/workflows/test.yml , .github/workflows/test_import.yml |
Updated actions versions, modified pip commands, added uv installation. |
.pre-commit-config.yaml |
Updated pre-commit hooks versions. |
docs/environment.yml , docs/rtd_environment.yml |
Updated channel URLs for conda-forge. |
docs/make_format.py , dpdata/__main__.py , dpdata/cli.py , dpdata/pymatgen/structure.py |
Improved string formatting for readability. |
dpdata/abacus/md.py , dpdata/abacus/relax.py , dpdata/abacus/scf.py , dpdata/data_type.py , dpdata/deepmd/hdf5.py , dpdata/fhi_aims/output.py , dpdata/format.py , dpdata/periodic_table.py , dpdata/pwmat/atomconfig.py , dpdata/stat.py , dpdata/system.py , dpdata/vasp/poscar.py |
Updated string formatting to f-strings. |
dpdata/plugins/pymatgen.py |
Added from_system method to PyMatgenStructureFormat class. |
pyproject.toml |
Updated setuptools_scm[toml] version requirement. |
tests/test_cli.py |
Added sys import, implemented TestClassScript . |
tests/test_from_pymatgen.py , tests/test_to_pymatgen.py |
Introduced new test cases, updated pymatgen imports. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.63%. Comparing base (
82de1f1
) to head (74a5553
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@coderabbitai regenerate summary
[!TIP] For best results, initiate chat on the files or code changes.
@njzjz, here is the regenerated summary based on the latest changes in the pull request:
New Files and Configurations:
.git_archival.txt
: Introduces metadata related to the Git repository..gitattributes
: Configures the export of git_archival.txt
using export-subst
.GitHub Workflows:
.github/workflows/test.yml
: Updated actions (checkout
to v4
and setup-python
to v5
), added uv
installation, and modified pip installation commands to include uv
before pip install
..github/workflows/test_import.yml
: Updated actions (checkout
to v4
and setup-python
to v5
), added uv
installation, and modified pip installation commands to include uv
before pip install
.Pre-commit Hooks:
.pre-commit-config.yaml
: Updated versions of pre-commit/pre-commit-hooks
to v4.6.0
and astral-sh/ruff-pre-commit
to v0.4.3
.Documentation and Environment Files:
docs/make_format.py
: Improved string formatting for better readability.docs/rtd_environment.yml
: Updated channel URLs from https://repo.mamba.pm/conda-forge
to conda-forge
.Codebase Enhancements:
%
to f-strings or .format()
for better readability and maintenance across multiple files (dpdata/abacus/md.py
, dpdata/abacus/relax.py
, dpdata/abacus/scf.py
, dpdata/cli.py
, dpdata/data_type.py
, dpdata/deepmd/hdf5.py
, dpdata/format.py
, dpdata/periodic_table.py
, dpdata/pwmat/atomconfig.py
, dpdata/vasp/poscar.py
).dpdata/fhi_aims/output.py
and dpdata/abacus/scf.py
.dpdata/plugins/pymatgen.py
: Added from_system
method to PyMatgenStructureFormat
.dpdata/pymatgen/structure.py
: Introduced from_system_data
function.dpdata/system.py
and dpdata/stat.py
.Testing Enhancements:
tests/test_cli.py
: Added import sys
and a new test case class TestClassScript
to check version output.tests/test_from_pymatgen.py
: Introduced a test case class TestFormPytmatgen
for creating and testing structures using pymatgen
.tests/test_to_pymatgen.py
: Updated import statement and method call for Structure
from pymatgen
.Dependency Updates:
pyproject.toml
: Updated setuptools_scm[toml]
version requirement from 6.2
to 7
.Let me know if you need any further modifications or details.
xref: