Closed pxlxingliang closed 3 days ago
tests/test_abacus_pw_scf.py (2)
`153-155`: **LGTM!** The `tearDown` method correctly handles file removal. --- `157-164`: **LGTM!** The `test_noforcestress_job` method correctly verifies the expected behavior of the `system_ch4` object.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Comparing pxlxingliang:scf-f
(e0b6b80) with devel
(fb85312)
✅ 2
untouched benchmarks
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.42%. Comparing base (
4bb4069
) to head (e0b6b80
). Report is 5 commits behind head on devel.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am wondering if it works, considering System
will check the shape of the data.
I am wondering if it works, considering
System
will check the shape of the data.
In current dpdata, it does work. It seems that the System
does not check the dimension of force.
Is there a specification for how to store force in a system without force?
Summary by CodeRabbit
Bug Fixes
None
instead of an empty list when no forces are present.Tests