deepmodeling / dpdata

A Python package for manipulating atomistic data of software in computational science
https://docs.deepmodeling.com/projects/dpdata/
GNU Lesser General Public License v3.0
203 stars 134 forks source link

add spin for lammps #738

Closed pxlxingliang closed 1 month ago

pxlxingliang commented 1 month ago

Reference #728 to add the spin information for lammps.

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough ## Walkthrough This pull request introduces several new functions and modifies existing ones to enhance the handling of spin data in LAMMPS dump files. A new function `get_spin_keys` is added to extract spin-related keys from a LAMMPS dump file, while `get_spin` retrieves spin data from the "ATOMS" block. The `get_spins` function processes atom lines for spin values. The `system_data` function is updated in both `dump.py` and `lmp.py` to include spin data in the returned system dictionary. Additionally, a new function `register_spin` is created to register spin data types, and new test files are added to validate these functionalities. ## Changes | File | Change Summary | |----------------------------------|----------------------------------------------------------------------------------------------------| | `dpdata/lammps/dump.py` | - Added `get_spin_keys(inputfile)` and `get_spin(lines, spin_keys)` functions.
- Updated `system_data` to include spins and modified its signature to include `input_file`. | | `dpdata/lammps/lmp.py` | - Added `get_spins(lines)` to extract and normalize spin values.
- Updated `system_data` and `from_system_data` to handle spins. | | `dpdata/plugins/lammps.py` | - Added `register_spin(data)` to register spin data types with `dpdata.System`.
- Updated `from_system` methods to include `input_file`. | | `tests/lammps/in.lmp` | - Added a new compute command for spin properties and a dump command for outputting spin data. | | `tests/lammps/spin.lmp` | - New file created to define a simulation setup with spin data. | | `tests/lammps/traj.dump` | - New file created containing simulation data formatted for LAMMPS. | | `tests/test_lammps_spin.py` | - Added unit tests for LAMMPS spin configurations, including methods in `TestLmp` and `TestDump`. | ## Possibly related PRs - #718: The changes in this PR involve the registration of spin data types and modifications to methods handling spin information, which aligns with the main PR's focus on introducing new functions for extracting and processing spin data in LAMMPS dump files. ## Suggested reviewers - wanghan-iapcm - njzjz

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #738 will not alter performance

Comparing pxlxingliang:lmp-spin (ef386da) with devel (cdbbe1b)

Summary

✅ 2 untouched benchmarks

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.55172% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (74bfccc) to head (ef386da). Report is 3 commits behind head on devel.

Files with missing lines Patch % Lines
dpdata/lammps/dump.py 94.23% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #738 +/- ## ========================================== + Coverage 84.80% 84.92% +0.12% ========================================== Files 81 81 Lines 7336 7418 +82 ========================================== + Hits 6221 6300 +79 - Misses 1115 1118 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.