deepmodeling / dpdispatcher

generate HPC scheduler systems jobs input scripts and submit these scripts to HPC systems and poke until they finish
https://docs.deepmodeling.com/projects/dpdispatcher/
GNU Lesser General Public License v3.0
42 stars 56 forks source link

raise FileNotFoundError in several contexts #416

Closed njzjz closed 10 months ago

njzjz commented 10 months ago

409 avoids retry in loop when the file is not found in the ssh context. But it is not apply to other contexts, and the tests hang in https://github.com/deepmodeling/dpgen/pull/1406 due to retry.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ec84d6e) 72.78% compared to head (33b47b9) 59.50%. Report is 1 commits behind head on master.

Files Patch % Lines
dpdispatcher/contexts/hdfs_context.py 0.00% 6 Missing :warning:
dpdispatcher/contexts/local_context.py 25.00% 6 Missing :warning:
dpdispatcher/contexts/ssh_context.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #416 +/- ## =========================================== - Coverage 72.78% 59.50% -13.28% =========================================== Files 36 37 +1 Lines 3601 3603 +2 =========================================== - Hits 2621 2144 -477 - Misses 980 1459 +479 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.