search

deepmodeling / dpdispatcher

generate HPC scheduler systems jobs input scripts and submit these scripts to HPC systems and poke until they finish
https://docs.deepmodeling.com/projects/dpdispatcher/
GNU Lesser General Public License v3.0
42 stars 56 forks source link

CI: setup uv #450

Closed njzjz closed 4 months ago

njzjz commented 4 months ago

Summary by CodeRabbit

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.88%. Comparing base (bec4f2e) to head (f2e23a2). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #450 +/- ## =========================================== - Coverage 59.99% 46.88% -13.11% =========================================== Files 36 36 Lines 3662 3662 =========================================== - Hits 2197 1717 -480 - Misses 1465 1945 +480 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

njzjz commented 4 months ago

I leave this PR as a draft until we want to deprecate Python 3.7.

coderabbitai[bot] commented 4 months ago
Walkthrough ## Walkthrough The recent updates focus on enhancing the Python dependency installation process across various GitHub workflows and Docker scripts. The introduction of `uv pip install --system` suggests a shift towards a unified installation approach, potentially improving system compatibility and dependency management. These changes affect the setup and execution of tests and other operations within Docker environments and continuous integration workflows. ## Changes | Files | Change Summary | |-------|----------------| | `.github/workflows/pyright.yml`, `.github/workflows/test-bohrium.yml`, `ci/pbs.sh`, `ci/slurm.sh`, `ci/ssh.sh`, `ci/ssh_rsync.sh` | Updated pip installation commands to include `uv pip install --system`, indicating a shift towards a more standardized and possibly system-integrated Python environment setup. | | `.github/workflows/test.yml` | Modified platform-specific installation using `curl` and `powershell` for Windows and updated coverage commands to use `python -m coverage`. |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between bec4f2e0b36ba9443c6015ff150381283c787986 and f2e23a267df28c63d2b95a3ffd2f984427ce6e4b.
Files selected for processing (7) * .github/workflows/pyright.yml (1 hunks) * .github/workflows/test-bohrium.yml (1 hunks) * .github/workflows/test.yml (1 hunks) * ci/pbs.sh (1 hunks) * ci/slurm.sh (1 hunks) * ci/ssh.sh (1 hunks) * ci/ssh_rsync.sh (1 hunks)
Files skipped from review due to trivial changes (1) * ci/slurm.sh
Additional comments not posted (11)
.github/workflows/pyright.yml (2)
`14-14`: Ensure the `uv` package is available in the Python package index before using `pip install uv`. --- `15-15`: Ensure that the `uv pip install --system` command is compatible with editable installs (`-e` option).
ci/ssh.sh (1)
`9-9`: Ensure that the `uv` tool is properly installed and configured within the Docker container before using it for dependency management.
ci/ssh_rsync.sh (1)
`13-13`: Ensure that the `uv` tool is properly installed and configured within the Docker container before using it for dependency management.
ci/pbs.sh (1)
`12-12`: Ensure that the `uv` tool is properly installed and configured within the Docker container before using it for dependency management. Also, verify that the `chown -R pbsuser .` command does not inadvertently change permissions on files that should not be modified.
.github/workflows/test.yml (4)
`28-28`: Ensure that the `curl` command successfully installs the `uv` tool on non-Windows platforms. Consider adding error handling to ensure the installation process does not silently fail. --- `30-30`: Ensure that the `powershell` command successfully installs the `uv` tool on Windows platforms. Consider adding error handling to ensure the installation process does not silently fail. --- `32-32`: Ensure that the `uv pip install --system` command is compatible with the project's dependency management requirements. --- `35-38`: The change to use `python -m coverage` instead of `coverage` directly is a good practice as it ensures that the correct Python interpreter is used. No further action needed.
.github/workflows/test-bohrium.yml (2)
`23-23`: Ensure the `uv` package is available in the Python package index before using `pip install uv`. --- `24-24`: Ensure that the `uv pip install --system` command is compatible with the Bohrium environment's dependency management requirements.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.