search

deepmodeling / dpdispatcher

generate HPC scheduler systems jobs input scripts and submit these scripts to HPC systems and poke until they finish
https://docs.deepmodeling.com/projects/dpdispatcher/
GNU Lesser General Public License v3.0
42 stars 56 forks source link

add "JH_UniScheduler" batch_type #459

Closed WangSimin123456 closed 3 months ago

WangSimin123456 commented 3 months ago

JH UniScheduler was developed by JHINNO company. JH UniScheduler is a commercial software and uses "jsub" to submit tasks. Its overall architecture is similar to that of IBM's LSF. However, there are still some differences between them.

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The update enhances the DPDispatcher Python package with support for a new scheduler system, JH UniScheduler. This includes documentation updates, the addition of a new class for JH UniScheduler operations, and relevant test cases. These changes broaden the package's capabilities in generating and managing HPC job scripts across different scheduler systems, improving its versatility and usability. ## Changes | Files | Change Summary | |-------------------------------------------------------|---------------------------------------------------------------------------------------------------------| | `doc/index.rst`, `doc/batch.md` | Updated documentation to include JH UniScheduler and its setup requirements. | | `dpdispatcher/machines/JH_UniScheduler.py` | Introduced `JH_UniScheduler` class with methods for job script generation, submission, status checking, and job termination. | | `pyproject.toml` | Added `jh_unischeduler` to the list of keywords. | | `tests/context.py`, `tests/test_class_machine_dispatch.py` | Added import statements and a test case for `JH_UniScheduler`. | | `tests/test_JH_UniScheduler_script_generation.py` | Added test cases for generating job scripts using JH UniScheduler. | | `tests/jsons/machine_JH_UniScheduler.json`, `tests/jsons/machine_lazy_local_jh_unischeduler.json` | Defined machine and resource configurations for JH UniScheduler. | | `tests/test_jh_unischeduler/.../conf.lmp`, `tests/test_jh_unischeduler/.../input.lammps` | Added LAMMPS simulation configuration and input files for testing. | | `tests/test_jh_unischeduler/0_md/graph.pb` | Added `graph.pb` file for testing purposes. |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 590feb64d0f66a26a86a9ff286dc8d2bc4f355b0 and 1453890860266f4962b4d4c9530dafbd12f23437.
Files selected for processing (1) * tests/test_class_machine_dispatch.py (2 hunks)
Files skipped from review as they are similar to previous changes (1) * tests/test_class_machine_dispatch.py
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 37.34940% with 52 lines in your changes missing coverage. Please review.

Project coverage is 47.55%. Comparing base (a040691) to head (1453890). Report is 24 commits behind head on master.

Files Patch % Lines
dpdispatcher/machines/JH_UniScheduler.py 37.34% 52 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (a040691) and HEAD (1453890). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (a040691) | HEAD (1453890) | |------|------|------| ||15|12|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #459 +/- ## =========================================== - Coverage 60.59% 47.55% -13.05% =========================================== Files 38 39 +1 Lines 3738 3821 +83 =========================================== - Hits 2265 1817 -448 - Misses 1473 2004 +531 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WangSimin123456 commented 3 months ago

Please fix all tests

Thank you for your comment. It already says "All checks have passed". Can we merge this branch and close this issue? Or what should be done next?