search

deepmodeling / dpdispatcher

generate HPC scheduler systems jobs input scripts and submit these scripts to HPC systems and poke until they finish
https://docs.deepmodeling.com/projects/dpdispatcher/
GNU Lesser General Public License v3.0
42 stars 56 forks source link

job_name in SGE system #470

Closed thangckt closed 1 month ago

thangckt commented 1 month ago

add option to set job_name in SGE system

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The recent changes enhance the configurability of job submissions in the PBS job handler by allowing dynamic job naming. The `gen_script_header` method now generates the job name from the job's resources, defaulting to "wDPjob" if not specified. Additionally, the `resources_subfields` method has been updated to accept an optional `job_name` argument, improving the flexibility and clarity of resource configurations. ## Changes | Files | Change Summary | |-----------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------| | `dpdispatcher/machines/pbs.py` | Modified `gen_script_header` to dynamically retrieve the job name, enhancing script header generation. Updated `resources_subfields` to include an optional `job_name` argument for better configurability. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant JobHandler participant JobResources JobHandler->>JobResources: Retrieve job name alt Job name exists JobResources-->>JobHandler: Return job name else No job name JobHandler-->>JobHandler: Use default "wDPjob" end JobHandler->>JobHandler: Generate script header with job name ```
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between dfa143d651846bda32f7ec8825a515c64e257fba and 9b1c566fb6e276092fc72dd400e822c2d5645571.
Files selected for processing (1) * dpdispatcher/machines/pbs.py (4 hunks)
Additional context used
GitHub Check: codecov/patch
dpdispatcher/machines/pbs.py
[warning] 217-217: dpdispatcher/machines/pbs.py#L217 Added line #L217 was not covered by tests --- [warning] 220-221: dpdispatcher/machines/pbs.py#L220-L221 Added lines #L220 - L221 were not covered by tests
Additional comments not posted (1)
dpdispatcher/machines/pbs.py (1)
`319-319`: **Verify the correctness of the new argument.** The new argument `job_name` is defined as an optional string with a default value of "wDPjob". Ensure that this logic is correct and that the argument is properly used in the codebase.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.48%. Comparing base (dfa143d) to head (9b1c566).

Files Patch % Lines
dpdispatcher/machines/pbs.py 25.00% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (dfa143d) and HEAD (9b1c566). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (dfa143d) | HEAD (9b1c566) | |------|------|------| ||15|14|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #470 +/- ## =========================================== - Coverage 59.97% 47.48% -12.49% =========================================== Files 39 39 Lines 3840 3843 +3 =========================================== - Hits 2303 1825 -478 - Misses 1537 2018 +481 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thangckt commented 1 month ago

@njzjz