search

deepmodeling / dpdispatcher

generate HPC scheduler systems jobs input scripts and submit these scripts to HPC systems and poke until they finish
https://docs.deepmodeling.com/projects/dpdispatcher/
GNU Lesser General Public License v3.0
45 stars 57 forks source link

CI: switch to docker compose v2 #479

Closed njzjz closed 3 months ago

njzjz commented 3 months ago

See https://github.com/actions/runner-images/issues/9692.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The recent updates across various CI scripts involve transitioning from the `docker-compose` command syntax to the newer `docker compose` syntax. This change enhances script consistency with current Docker practices while maintaining the existing functionality of each script. No alterations were made to exported or public entities, ensuring a seamless integration of the updated commands. ## Changes | Files | Change Summary | |-----------------------------------|--------------------------------------------------------------------------------------------------------| | `ci/pbs.sh`, `ci/slurm.sh`, `ci/ssh.sh`, `ci/ssh_rsync.sh` | Updated from `docker-compose pull` to `docker compose pull`, aligning with the newer Docker CLI syntax. | | `ci/pbs/start-pbs.sh`, `ci/slurm/start-slurm.sh`, `ci/ssh/start-ssh.sh` | Changed from `docker-compose up -d --no-build` to `docker compose up -d --no-build`, maintaining script functionality. | | `ci/slurm/register_cluster.sh` | Modified command from `docker-compose` to `docker compose` for restarting services, ensuring compliance with updated standards. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 1f1bacfcab26693a5f5314561707382875962a33 and 7e169e44fd3997bdc9fb15bb882305a9e110e004.
Files selected for processing (8) * ci/pbs.sh (1 hunks) * ci/pbs/start-pbs.sh (1 hunks) * ci/slurm.sh (1 hunks) * ci/slurm/register_cluster.sh (1 hunks) * ci/slurm/start-slurm.sh (1 hunks) * ci/ssh.sh (1 hunks) * ci/ssh/start-ssh.sh (1 hunks) * ci/ssh_rsync.sh (1 hunks)
Files skipped from review due to trivial changes (6) * ci/pbs/start-pbs.sh * ci/slurm/register_cluster.sh * ci/slurm/start-slurm.sh * ci/ssh.sh * ci/ssh/start-ssh.sh * ci/ssh_rsync.sh
Additional comments not posted (2)
ci/slurm.sh (1)
`5-5`: **LGTM! The command syntax is correct.** The transition from `docker-compose pull` to `docker compose pull` is accurate and aligns with Docker Compose v2 syntax.
ci/pbs.sh (1)
`5-5`: **LGTM! The command syntax is correct.** The transition from `docker-compose pull` to `docker compose pull` is accurate and aligns with Docker Compose v2 syntax.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.46%. Comparing base (1f1bacf) to head (7e169e4). Report is 18 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (1f1bacf) and HEAD (7e169e4). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (1f1bacf) | HEAD (7e169e4) | |------|------|------| ||15|14|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #479 +/- ## =========================================== - Coverage 59.91% 47.46% -12.45% =========================================== Files 39 39 Lines 3849 3849 =========================================== - Hits 2306 1827 -479 - Misses 1543 2022 +479 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.