search

deepmodeling / dpgen2

2nd generation of the Deep Potential GENerator
https://docs.deepmodeling.com/projects/dpgen2/
GNU Lesser General Public License v3.0
33 stars 26 forks source link

Refactor finetune #247

Closed zjgemi closed 3 months ago

zjgemi commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago
Walkthrough ## Walkthrough The recent updates to the `dpgen2` project simplify finetuning management and parameter handling by eliminating the explicit finetuning step and integrating it into existing workflows. This streamlining enhances maintainability, reduces complexity in training command generation, and improves the handling of optional parameters across various modules, ultimately leading to clearer and more efficient code. ## Changes | Files/Directories | Change Summary | |-----------------------------------------------------|------------------------------------------------------------------------------------------------------------| | `dpgen2/entrypoint/submit.py` | Removed `make_finetune_step` and integrated finetuning into `workflow_concurrent_learning`, updating return values to streamline the workflow. | | `dpgen2/flow/dpgen_loop.py` | Added `make_next_optional_parameter` to consistently set `finetune_mode` to "no" during scheduling. | | `dpgen2/op/run_dp_train.py` | Simplified model initialization logic by removing redundant checks, clarifying conditions for model training. | | `dpgen2/superop/prep_run_dp_train.py` | Removed `ModifyTrainScript` class and related methods, simplifying the `PrepRunDPTrain` class and its parameter handling. | | `dpgen2/utils/dflow_query.py` | Eliminated checks for "finetune" patterns, streamlining key identification logic in regex functions. | | `tests/mocked_ops.py` | Removed `MockedModifyTrainScript` class and its `execute` method, simplifying test structure and dependencies. | | `tests/test_prep_run_dp_train.py` | Removed tests for `ModifyTrainScript`, refocusing on `MockedPrepDPTrain` and `MockedRunDPTrain`, simplifying the test suite. | | `tests/utils/test_dflow_query.py` | Removed "finetune" entries from `dpgen_keys` and associated test cases, streamlining expected outputs. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant Workflow participant Model User->>Workflow: Start Training Workflow->>Model: Initialize Model alt Finetuning Enabled Model->>Workflow: Check finetune parameters Workflow->>Model: Set to finetune mode end Workflow->>Model: Execute Training Model->>Workflow: Training Results Workflow->>User: Return Results ```
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 33bac052293c737cb48dd7db06e8c90510a223f4 and ef494e90bc94a24209222ab18af8480ac9418bb0.
Files selected for processing (2) * dpgen2/op/run_dp_train.py (2 hunks) * tests/op/test_run_dp_train.py (5 hunks)
Files skipped from review as they are similar to previous changes (2) * dpgen2/op/run_dp_train.py * tests/op/test_run_dp_train.py
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (f5c5d95) to head (ef494e9). Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
dpgen2/entrypoint/submit.py 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== - Coverage 83.84% 83.75% -0.10% ========================================== Files 97 97 Lines 5368 5318 -50 ========================================== - Hits 4501 4454 -47 + Misses 867 864 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.