Closed njzjz closed 5 months ago
The recent updates to the ReacNetGenerator involve refactoring the main class to function as a factory and modifying command line parser options. The ReacNetGenerator
class is now a factory for creating instances, enhancing flexibility in object creation. Additionally, the choices for the "--type" argument in the command line have been simplified to a fixed list, improving clarity and predictability for users.
File | Change Summary |
---|---|
.../__init__.py |
Refactored ReacNetGenerator class into a factory, introducing a new __new__ method for instance creation. |
.../commandline.py |
Modified the "--type" argument choices in main_parser to a predefined list: ["bond", "lammpsbondfile", "dump", "lammpsdumpfile", "xyz"]. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.23%. Comparing base (
a1e56b3
) to head (f99659e
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Comparing njzjz:lazy-import
(f99659e) with master
(1450abd)
⚡ 1
improvements
✅ 7
untouched benchmarks
Benchmark | master |
njzjz:lazy-import |
Change | |
---|---|---|---|---|
⚡ | test_cli |
2.2 ms | 1.7 ms | +34.6% |
Summary by CodeRabbit
Refactor
ReacNetGenerator
class to enhance object creation efficiency.New Features