search

deepneuroscience / Rethinking-Eye-blink

Rethinking Eye-Blink (CHI2021)
7 stars 2 forks source link

Sliding window size #3

Open william-davies opened 3 years ago

william-davies commented 3 years ago

https://github.com/deepneuroscience/Rethinking-Eye-blink/blob/e4ad06008ac79735468ef7e2824cf906f4addcd7/rethinking_eyeblink/utils/blink_spectrogram.py#L11-L17

On page 6 of Cho 2021, it says that the sliding window size is 61 seconds:

The first cutoff frequency determines the upper time limit of blinking (30 seconds), setting the window length to the upper limit multiplied by 2, followed by the addition of 1 (60+1 seconds).

However, in blink_spectrogram, the window size appears to be 30 seconds. I just wanted to check if I misunderstood something or if there is a reason the window sizes are slightly different?

Thank you!

deepneuroscience commented 3 years ago

Firstly, I refer to this article P.11, describing how to determine the window size. https://www.osapublishing.org/boe/fulltext.cfm?uri=boe-8-10-4480&id=372762

Secondly, note that this is a demo code - so parameters have to be chosen for each case. Looking into the code quickly, it seems like w = gausswin(lag) needs to be w = gausswin(2*lag +1) Please check the window size from the code if this works.