search

deepnight / ldtk-haxe-api

LDtk level editor Haxe API (available on HaxeLib)
MIT License
94 stars 31 forks source link

add dependency, update README #13

Closed JRJurman closed 2 years ago

JRJurman commented 3 years ago

Summary

This PR adds the deepnightLibs dependency to the haxelib.json file, which should resolve #11 and #12

In the process of making this PR, I ran into an error where I needed to install hlsdl, so I added that to the README. 

➜  samples git:(master) ✗ haxe buildAll.hxml 
Error: Error: Cannot process [hlsdl]: Library hlsdl is not installed : run 'haxelib install hlsdl'

I can change that part in the README, or take it out of this PR, if that shouldn't be included in here.

Testing

Ran the JS tests, and it returned with a success message

➜  ldtk-haxe-api git:(master) ✗ haxe tests/js.hxml 

Success.

Caveats

I've never done Haxe development of any kind, so I have no idea if this is good or right :man_shrugging:

deepnight commented 2 years ago

Hello, Thanks for the PR. I will only change one thing after merge: the dependency in haxelib.json should be pointing to latest release of deepnightLibs version instead of a specific one :)