deepnight / ldtk

Modern, lightweight and efficient 2D level editor
https://ldtk.io
MIT License
3.43k stars 189 forks source link

Inquiry About the Integer Limit for Custom Entity Fields in LDtk #1130

Open mungsaja opened 2 months ago

mungsaja commented 2 months ago

Hello,

I’ve been working with LDtk and noticed that when setting custom fields for entities, the maximum allowable integer value seems to be capped at 2,000,000. Could you please clarify the specific reason for this limit? Is it due to JSON handling, internal engine constraints, or another technical consideration?

thanks.

deepnight commented 2 months ago

I honestly don't think there's a real reason other than me quickly figuring out a cross-platform limit to Integers when I entered that value.

If you happen to have a better idea on that limit on most classic platforms (JS, C#, C++, etc) that would be super useful and I could adjust the limit accordingly 👍

mungsaja commented 2 months ago

I honestly don't think there's a real reason other than me quickly figuring out a cross-platform limit to Integers when I entered that value.

If you happen to have a better idea on that limit on most classic platforms (JS, C#, C++, etc) that would be super useful and I could adjust the limit accordingly 👍

First of all, thank you for your reply. I couldn't find specific guidance on the integer limit, so I assumed that the maximum value of a 32-bit integer, which is around 2.1 billion, would be possible. Based on this, I assigned custom ID values exceeding 2 million to entities across various levels. Since the values appeared as entered until the saving process, I didn’t realize the issue until after importing the data into Unity. Upon import, I saw that the values for all entities were reset, which made me realize there was a limit.

It would be great if the full range of 32-bit integer values could be used. Alternatively, it would be helpful to have visual feedback in the input field when the limit is exceeded.