deepsea887 / sigplus

Automatically exported from code.google.com/p/sigplus
0 stars 0 forks source link

Kunena. Icon "download" saves corrupted file? #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This issue tracker is for sigplus-1.5.0.175

Hi!
In lightbox preview, click to icon "download" saves corrupted file.

The saved file has the correct size, but the extension is not graphic file 
photo?

I enclose the original file and the file downloaded from the gallery located in 
the post Kunena.
File downloaded using the icon "download" is overwritten header.

or look to my serwer to patch /kunena/suggestion-box/8-sigplus-gallery.

Original issue reported on code.google.com by ten.mari...@gmail.com on 7 Jan 2013 at 10:28

Attachments:

GoogleCodeExporter commented 9 years ago
I enclose the original file and the file downloaded from the gallery located in 
the post Kunena.
File downloaded using the icon "download" is overwritten header.

Original comment by ten.mari...@gmail.com on 7 Jan 2013 at 11:51

Attachments:

GoogleCodeExporter commented 9 years ago
This looks like a Kunena issue rather than a sigplus issue. When you click the 
button "Download" in the lightbox pop-up window, you trigger a link with a 
specially crafted URL, which causes sigplus to short-circuit the normal gallery 
generation (terminating Joomla with a call to jexit) and instead produce a 
binary file. Appropriate HTTP headers are sent to indicate the browser the file 
is an attachment (in HTTP terminology) and it should prompt the "Save as..." 
dialog box. However, if HTTP headers have already been sent (possibly by 
Kunena) by the time sigplus tries to send its own, those by sigplus will be 
ignored by PHP. This means no indication will be sent that the file is an 
attachment, and the browser will display the contents of the file in a regular 
tab. This does not mean the file is corrupt, in fact the characters in the 
attached image indeed look like the first part of an image file.

In order to track down the exact cause of the issue, a similar setup as yours 
must be put together in our test environment, which reproduces the issue, 
hopefully with some easy steps. (I do not want to delve into how Kunena works, 
which would be a time-consuming side-track from a sigplus perspective.) 
Alternatively, you might want to check if you encounter the multiple headers 
sent issue in your own environment, and report what you find.

Original comment by huny...@gmail.com on 24 Mar 2013 at 10:30

GoogleCodeExporter commented 9 years ago
The image download routine in sigplus version 1.5.0.182 and later checks if 
HTTP headers have already been sent before it copies image file binary content 
into the HTTP payload to be returned to the browser that initiated the request. 
If headers have been sent, an error message informs the user about a possible 
conflict with another extension. Similarly, the user gets an error message when 
they try to manipulate URLs to access images they otherwise have no permission 
to download.

Original comment by huny...@gmail.com on 30 Mar 2013 at 4:11

GoogleCodeExporter commented 9 years ago
Thank you for your fixes sigplus-1.5.0.183.zip
Unfortunately, the error still occurs. It occurs only in posts Kunena.

You can check it out on my test page, after logging in, in the menu: "Testing / 
SigPlus / Saved SigPlus icon Kunena"

This version has improved malfunction "lightbox", now I have to change the 
arrow next picture.

Original comment by ten.mari...@gmail.com on 3 Apr 2013 at 7:26

GoogleCodeExporter commented 9 years ago
Unfortunately, the part of the issue that remains to be there seems to be in 
the domain of Kunena and not in the domain of sigplus. When I check out the 
corrupted file that is downloaded, I see that the binary JPEG file is there but 
there is some Kunena HTML content prepended to the output. It looks like Kunena 
does not respect the call to jexit or interferes with the regular path of 
Joomla generating content. Since the error appears to relate to Kunena and 
outside of sigplus, there is little I can do to overcome the problem. (Do 
plug-ins similar to sigplus work in Kunena topics?) Perhaps you might want to 
report it to Kunena developers. If they require technical advice regarding the 
context of the problem (i.e. how downloading images in sigplus works), they can 
use the sigplus support e-mail (free of charge).

Original comment by huny...@gmail.com on 3 Apr 2013 at 8:26

GoogleCodeExporter commented 9 years ago
Thank you. taken:

http://www.kunena.org/forum/K-2-0-Support/127161-kunena-add-content-to-a-graphic
s-file-sigplus#142256

Original comment by ten.mari...@gmail.com on 3 Apr 2013 at 8:45

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Hi!
Please help me.
In comparison the latest version sigplus and Kunena, the problem returned. : (

Sig Plus sigplus-1.5.0.203
Kunena: 3.0.4

http://www.kunena.org/forum/k-2-0-miscellaneous-third-party-extensions-archive/1
23183-k-2-0-sigplus-gallery-plugin?start=20#142263

Best Regards!

Original comment by ten.mari...@gmail.com on 5 Mar 2014 at 11:32