deepsea887 / sigplus

Automatically exported from code.google.com/p/sigplus
0 stars 0 forks source link

One file crash page effects #84

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Joomla! 2.5.14, sigplus-1.5.0.187.zip, {gallery} aricle.

Add to folder attached files causes the following errors or paralysis of the 
entire page.

test.jpg - crash page effects
test.png - Error raport

Best Regards!

Original issue reported on code.google.com by ten.mari...@gmail.com on 27 Aug 2013 at 8:33

Attachments:

GoogleCodeExporter commented 9 years ago
This report uncovers several issues, all of which have been fixed in the latest 
sigplus version.

First, sigplus uses COM ADODB.Stream input/output functions to support 
characters outside of the ASCII range in file names on machines with Windows 
OS. This is a workaround for PHP file system functions that do not support 
special characters (e.g. accented characters) on Windows. (The issue is 
specific to Windows OS, and never pops up on Linux machines.) Unfortunately, 
ADODB.Stream functions are much less reliable than standard functions, as 
manifested by the attached error log. sigplus code has been updated to use 
ADODB.Stream functions only when the file path contains non-ASCII characters, 
and use the PHP file system functions otherwise. (Behavior on Linux is 
unchanged.)

Second, when preview images and thumbnails are generated, extremely narrow and 
elongated images may zoom into a box one of whose sides is less than 1px, which 
has been rounded towards 0 in previous versions. This has produced invalid 
image dimensions, and no preview and/or thumbnail image was subsequently 
generated. sigplus code has been updated to force a minimum width and height of 
1px for all generated images.

Third, the JPEG file in the error report is actually a PNG file. This can 
generate warning message with PHP image processing functions, which is the 
correct and expected behavior. Do not use JPEG images with the extension ".png" 
or vice versa.

Original comment by huny...@gmail.com on 11 Sep 2013 at 5:45

GoogleCodeExporter commented 9 years ago
Thank you! lovely work. I'll be tested on.

Original comment by ten.mari...@gmail.com on 14 Sep 2013 at 1:50

GoogleCodeExporter commented 9 years ago
"the JPEG file in the error report is actually a PNG file."
— This is a frequent and recurring problem users of OS X. The Temne do not 
care about those extensions, and it is difficult to find such a file before 
loading the internet.

Original comment by ten.mari...@gmail.com on 14 Sep 2013 at 1:55