search

deepsense-ai / roi-pooling

460 stars 127 forks source link

The third ROI coordinate comment is not correct #5

Closed panovr closed 7 years ago

panovr commented 7 years ago

In "roi_pooling_minimal_example.ipynb":

# * channel 0, rectangular region (1, 0) to (3, 2)
#              ....
#              xxx.
#              xxx.
#              xxx.

I think this comment should be:

# * channel 0, rectangular region (1, 0) to (3, 2)
#              .xxx
#              .xxx
#              .xxx
#              ....
tgrel commented 7 years ago

@stared any opinions on that?

stared commented 7 years ago

@tgrel Sure! @panovr You are right, thank you for bringing this issue. I created a PR fixing this problem.

panovr commented 7 years ago

@tgrel @stared Thanks!