search

deepset-ai / FARM

:house_with_garden: Fast & easy transfer learning for NLP. Harvesting language models for the industry. Focus on Question Answering.
https://farm.deepset.ai
Apache License 2.0
1.74k stars 247 forks source link

String comparison with "is" #773

Closed johann-petrak closed 3 years ago

johann-petrak commented 3 years ago

See https://github.com/deepset-ai/FARM/blob/0357634c1997fe39b6f6e78827d35e43538caab1/farm/modeling/adaptive_model.py#L583

Should replace "is" with "=="

I do not think this is likely to cause a problem, but it depends on the way how Python string interning works.