According to the paper, the smell is described as follows:
Problem
If the columns are not selected explicitly, it is not easy for developers to know what to expect in the downstream data schema. If the datatype is not set explicitly, it may silently continue the next step even though the input is unexpected, which may cause errors later. The same applies to other data importing scenarios.
Solution
It is recommended to set the columns and DataType explicitly in data processing.
Hello!
I found an AI-Specific Code smell in your project. The smell is called: Columns and DataType Not Explicitly Set
You can find more information about it in this paper: https://dl.acm.org/doi/abs/10.1145/3522664.3528620.
According to the paper, the smell is described as follows:
Example:
You can find the code related to this smell in this link: https://github.com/deepset-ai/FARM/blob/94c6b8d88486359a9aae694d094783e7baff07b1/farm/modeling/wordembedding_utils.py#L137-L157.
I also found instances of this smell in other files, such as:
File: https://github.com/deepset-ai/FARM/blob/master/farm/utils.py#L352-L362 Line: 357 File: https://github.com/deepset-ai/FARM/blob/master/farm/utils.py#L420-L430 Line: 425 File: https://github.com/deepset-ai/FARM/blob/master/farm/evaluation/msmarco_passage_farm.py#L70-L80 Line: 75 .
I hope this information is helpful!