feat: adding skipped file names to warnings

deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud

Apache License 2.0

9 stars 2 forks source link

Closed elundaeva closed 1 year ago

elundaeva commented 1 year ago

Skipped files will be listed in the warning message.

[x] I have updated the referenced issue with new insights and changes
[ ] If this is a code change, I have added unit tests
[x] I've used the conventional commit specification for my PR title
[N/A] I updated the docstrings
[N/A] If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

github-actions[bot] commented 1 year ago

The coverage rate went from 92.89% to 92.91% :arrow_up: The branch rate is 80%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

### deepset_cloud_sdk/_service/files_service.py `100%` of new lines are covered (`94.36%` of the complete file).

elundaeva commented 1 year ago

@ArzelaAscoIi please take a look when you have a second 🙏 Also, do you think a small change like this requires unit testing?