fix: drop double encoding

deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud

Apache License 2.0

9 stars 2 forks source link

Closed wochinge closed 1 year ago

wochinge commented 1 year ago

FormData is already encoding stuff. No need to do it twice.

[ ] I have updated the referenced issue with new insights and changes
[ ] If this is a code change, I have added unit tests
[ ] I've used the conventional commit specification for my PR title
[ ] I updated the docstrings
[ ] If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

wochinge commented 1 year ago

Does this mean that we encoded it twice and therefore saw the encoding errors ?

We encoded it twice. Which means that we still need to decode in the main-api (but currently we'd have to decode twice)

github-actions[bot] commented 1 year ago

The coverage rate went from 92.91% to 92.9% :arrow_down: The branch rate is 80%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

### deepset_cloud_sdk/_s3/upload.py `100%` of new lines are covered (`91.13%` of the complete file).