deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud
Apache License 2.0
9 stars 1 forks source link

Case Sensitivity Issue in Filename Validation During Uploads #184

Closed ArzelaAscoIi closed 4 months ago

ArzelaAscoIi commented 4 months ago

Title: Filename Case Sensitivity Handling Causes Upload Errors

Description: A recent update to the Deepset SDK has introduced a bug in filename validation where case sensitivity is inconsistently handled. This issue leads to upload failures when filenames contain uppercase letters, as the SDK does not uniformly apply lowercase conversion.

Details: The inconsistency stems from a change made in a recent commit, which affects the method def _validate_file_paths. The method fails to recognize filenames that are not in lowercase, generating an error list. This issue can be traced back to this commit: Commit Link.

Proposed Solution: Standardize the case handling by applying lower() consistently across all filename checks, or adjust the file_name_set to be case-insensitive.