fix: total filtered download - Githubissues

deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud

Apache License 2.0

9 stars 2 forks source link

fix: total filtered download #187

Closed ArzelaAscoIi closed 6 months ago

ArzelaAscoIi commented 6 months ago

Related Issues

fixes https://deepset.atlassian.net/browse/DC-1125

Proposed Changes?

pass name, content and odata_filters to paginated list to calculate the total filtered files

How did you test it?

existing tests

Checklist

[ ] I have updated the referenced issue with new insights and changes
[ ] If this is a code change, I have added unit tests
[ ] I've used the conventional commit specification for my PR title
[ ] I updated the docstrings
[ ] If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

swarmia[bot] commented 6 months ago

✅ Linked to Bug DC-1125 · Wrong progress status when downloading files

github-actions[bot] commented 6 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
deepset_cloud_sdk/_service
files_service.py
Project Total

This report was generated by python-coverage-comment-action

ArzelaAscoIi commented 6 months ago

If this was covered by existing tests - why didn't we catch it before?

I was expecting that a test fails and i just quickly fix it. But turns out that there was no unit test for the progress par 🙃 added it