fix: api ur ending - Githubissues

deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud

Apache License 2.0

9 stars 2 forks source link

fix: api ur ending #29

Closed ArzelaAscoIi closed 1 year ago

ArzelaAscoIi commented 1 year ago

Related Issues

hotfix

Proposed Changes?

fix allow url to end with /

Checklist

[ ] I have updated the referenced issue with new insights and changes
[ ] If this is a code change, I have added unit tests
[ ] I've used the conventional commit specification for my PR title
[ ] I updated the docstrings
[ ] If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 85% to 85% :arrow_down: The branch rate is 74%.

80% of new lines are covered.

Diff Coverage details (click to unfold)

### deepset_cloud_sdk/api/config.py `100%` of new lines are covered (`95%` of the complete file). ### deepset_cloud_sdk/s3/upload.py `0%` of new lines are covered (`34%` of the complete file). Missing lines: `156` ### deepset_cloud_sdk/cli.py `100%` of new lines are covered (`100%` of the complete file).