search

deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud
Apache License 2.0
9 stars 2 forks source link

fix: upload error handling #39

Closed rjanjua closed 1 year ago

rjanjua commented 1 year ago

Fixes retrying issues for S3 Uploads

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 98% to 97% :arrow_down: The branch rate is 93%.

72% of new lines are covered.

Diff Coverage details (click to unfold) ### deepset_cloud_sdk/s3/upload.py `69%` of new lines are covered (`96%` of the complete file). Missing lines: `35`, `146`, `147`, `154`, `155` ### deepset_cloud_sdk/service/files_service.py `100%` of new lines are covered (`97%` of the complete file).
ArzelaAscoIi commented 1 year ago

Lets add tests for it too (in a followup. Its fine)