feat: comments from @oryx1729

deepset-ai / deepset-cloud-sdk

A Python SDK to interact with deepset Cloud

Apache License 2.0

9 stars 2 forks source link

feat: comments from @oryx1729 #43

Closed ArzelaAscoIi closed 1 year ago

ArzelaAscoIi commented 1 year ago

Related Issues

hotfix

Proposed Changes?

make login explicit for sdk
remove default workspace from sdk to use env but keep commented
make explicit when to use the upload texts
add progress bar for waiting for ingestion
set debug level to info

How did you test it?

not yet

Checklist

[ ] I have updated the referenced issue with new insights and changes
[ ] If this is a code change, I have added unit tests
[ ] I've used the conventional commit specification for my PR title
[ ] I updated the docstrings
[ ] If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 97% to 97% :arrow_up: The branch rate is 94%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

### deepset_cloud_sdk/service/files_service.py `100%` of new lines are covered (`97%` of the complete file). ### deepset_cloud_sdk/__init__.py `100%` of new lines are covered (`100%` of the complete file).